Bug #1139
oident implementation breaks windows builds
100%
Description
The Windows build of the 0.8-beta1 does not compile
The error is the following:[ 21%] Building CXX object src/core/CMakeFiles/mod_core.dir/oidentdconfiggenerator.cpp.obj
oidentdconfiggenerator.cpp
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2065: 'mode_t': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2146: Syntaxfehler: Fehlendes ';' vor Bezeichner 'prev_umask'
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2065: 'prev_umask': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2065: 'S_IXUSR': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2065: 'S_IWGRP': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2065: 'S_IXGRP': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2065: 'S_IWOTH': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C2065: 'S_IXOTH': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(105) : error C3861: "umask": Bezeichner wurde nicht gefunden.
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(107) : error C2065: 'prev_umask': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\oidentdconfiggenerator.cpp(107) : error C3861: "umask": Bezeichner wurde nicht gefunden.
NMAKE : fatal error U1077: "C:\PROGRA~2\MICROS~2.0\VC\bin\amd64\cl.exe": Rückgabe-Code "0x2"
Stop.
NMAKE : fatal error U1077: ""C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\amd64\nmake.exe"": Rückgabe-Code "0x2"
Stop.
NMAKE : fatal error U1077: ""C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\amd64\nmake.exe"": Rückgabe-Code "0x2"
Stop.
Associated revisions
don't use umask on Windows
Fixes #1139
History
#1 Updated by cpuesser almost 13 years ago
- File 0001-fix-oidentconfigger-build-under-windows.patch 0001-fix-oidentconfigger-build-under-windows.patch added
Seems even like the whole module shouldn't be build under windows, as there is no oident build.
If it should be possible to build the config anyway i.e. for a linux router in the network the attached patch should work.
#2 Updated by cpuesser almost 13 years ago
- File 0001-fix-oidentconfigger-build-under-windows.patch 0001-fix-oidentconfigger-build-under-windows.patch added
Sorry, but in the first one the permissions for the umask were wrong.
#3 Updated by al over 12 years ago
- Status changed from New to Assigned
- Assignee set to al
- % Done changed from 0 to 100
#4 Updated by Anonymous over 12 years ago
- Status changed from Assigned to Resolved
Applied in changeset 26ab99ecabdbff2c7b66dc28039fe904bbce0520.
#5 Updated by cpuesser over 12 years ago
- Status changed from Resolved to Feedback
Sorry, but that doesn't fix the build,
umask is known under windows but there are two things.
At first umask is in windows deklared in the io.h
and the masks are named different under windows, so it doesn't build at all.
D:\Neuer Ordner\quassel\src\core\core.cpp(83) : error C2065: 'S_IRWXG': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\core.cpp(83) : error C2065: 'S_IRWXO': nichtdeklarierter Bezeichner
D:\Neuer Ordner\quassel\src\core\core.cpp(83) : error C3861: "umask": Bezeichner wurde nicht gefunden.
#6 Updated by Anonymous over 12 years ago
- Status changed from Feedback to Resolved
Applied in changeset b2034ad5df2d6bf6b7a40899083a16909193912e.
#7 Updated by cpuesser over 12 years ago
Thank, builds and works.
let CMake check for umask()
Fixes #1139