Project

General

Profile

Bug #339

InputLine behaviour is sometimes unexpected

Added by al over 15 years ago. Updated over 15 years ago.

Status:
Resolved
Priority:
High
Assignee:
EgS
Category:
Quassel Client
Target version:
0.3.1
Start date:
Due date:
% Done:

0%

Estimated time:
Version:
0.13.1
OS:
Any

Description

- The InputLine is cleared on KeyUp/Down events when a history entry is changed
- Changed InputLine history entries are immediately appended to the history, regardless of actually getting sent

Additional information:

The attached patch does the following:
- The InputLine isn't cleared as often (KeyUp/Down)
- Changed InputLine history entries are preserved until a line is sent
- As soon as a new line is sent, changed history entries are replaced by the unchanged lines and
- the sent line gets appended to the history

0001-InputLine-history-handling-improved.patch (3.85 KB) 0001-InputLine-history-handling-improved.patch admin, 10/07/2008 06:09 PM
0001-also-preserve-temporary-history-entries-on-the-last.patch (873 Bytes) 0001-also-preserve-temporary-history-entries-on-the-last.patch admin, 10/10/2008 05:32 PM
0001-also-preserve-temporary-history-entries-on-the-last2.patch (873 Bytes) 0001-also-preserve-temporary-history-entries-on-the-last2.patch admin, 10/12/2008 05:24 PM
0001-clear-InputLine-on-Key_Down.patch (1.48 KB) 0001-clear-InputLine-on-Key_Down.patch admin, 10/13/2008 12:07 PM
0001-InputLine-history-handling-improved_betterthanever.patch (4.15 KB) 0001-InputLine-history-handling-improved_betterthanever.patch admin, 10/19/2008 01:49 PM

History

#1 Updated by al over 15 years ago

0001-also-preserve-temporary-history-entries-on-the-last2.patch replaces 0001-also-preserve-temporary-history-entries-on-the-last.patch

#2 Updated by al over 15 years ago

0001-clear-InputLine-on-Key_Down.patch:

If the user is on the most recent tempHistory line (== history.count() + 1) and presses Key_Down, reset InputLine.
The content of this line gets deleted.

#3 Updated by al over 15 years ago

0001-InputLine-history-handling-improved_betterthanever.patch attached
This patch obsoletes all other patches in this BR :>

#4 Updated by EgS over 15 years ago

applied 0001-InputLine-history-handling-improved_betterthanever.patch.

Also available in: Atom PDF